Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r209066014
--- Diff:
solr/core/src/test/org/apache/solr/update/TestNestedUpdateProcessor.java ---
@@ -107,8 +107,8 @@ public void testDeeplyNestedURPGrandChild() throws
Exception {
};
indexSampleData(jDoc);
- assertJQ(req("q", IndexSchema.NEST_PATH_FIELD_NAME + ":*/grandChild#*",
- "fl","*",
+ assertJQ(req("q", IndexSchema.NEST_PATH_FIELD_NAME + ":*/grandChild",
+ "fl","*, _nest_path_",
--- End diff --
This change (and others here) to a test of an URP that isn't modified in
this issue underscores my point made previously having the test for that URP be
more of a unit test of what the URP produces (test the SolrInputDocument), and
_not_ executing queries. I'm not saying it was wrong to make this change in
this issue but just want you to reflect on the ramifications of these choices.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
