[
https://issues.apache.org/jira/browse/LUCENE-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577020#comment-16577020
]
Lucene/Solr QA commented on LUCENE-8449:
----------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 0m 23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 0m 23s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
30s{color} | {color:green} highlighter in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 2m 52s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8449 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12935005/LUCENE-8449.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.4.0-130-generic #156~14.04.1-Ubuntu SMP Thu
Jun 14 13:51:47 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / cdc0959 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_172 |
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/73/testReport/ |
| modules | C: lucene/highlighter U: lucene/highlighter |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/73/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Code Optimizations in FieldTermStack
> ------------------------------------
>
> Key: LUCENE-8449
> URL: https://issues.apache.org/jira/browse/LUCENE-8449
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/highlighter
> Reporter: Namgyu Kim
> Priority: Minor
> Labels: newbie, performance
> Attachments: LUCENE-8449.patch
>
>
> -1) "vector.hasPositions() == false" in FieldTermStack's constructor-
> -can be changed to "*!vector.hasPositions()*"-
>
> 2) "public TermInfo(String, int, int, int, float)" constructor
> can be change to "*TermInfo(String, int, int, int, float)*"
>
> 3) TermInfo's toString method
> {code:java}
> public String toString() {
> StringBuilder sb = new StringBuilder();
> sb.append( text ).append( '(' ).append(startOffset).append ( ','
> ).append( endOffset ).append( ',' ).append( position ).append( ')' );
> return sb.toString();
> }{code}
> This code can be changed to
>
> {code:java}
> public String toString(){
> return text + '(' + startOffset + ',' + endOffset + ',' + position + ')';
> }
> {code}
> this code.
>
>
> 4) TermInfo's equals method
> {code:java}
> public boolean equals(Object obj) {
> ...
> if (position != other.position) {
> return false;
> }
> return true;
> }
> {code}
> This code can be changed to
>
> {code:java}
> public boolean equals(Object obj) {
> ...
> return position == other.position;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
