[
https://issues.apache.org/jira/browse/SOLR-12055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579705#comment-16579705
]
Shawn Heisey commented on SOLR-12055:
-------------------------------------
I finally had to give up trying for a good test run after the changes. I did
it a lot of times, there was a problem every time. Finally I decided to run
with -Dtests.haltonfailure=false so it would ignore failures and run every
test. Then I went to bed. Here's the result:
{noformat}
BUILD SUCCESSFUL
Total time: 66 minutes 54 seconds
{noformat}
There were some failures in core, which I haven't investigated yet to see if
they're caused by the log4j config change. This is entirely possible -- they
are logging tests.
{noformat}
[junit4] Tests with failures [seed: D8F6E7C3F7A92337]:
[junit4] -
org.apache.solr.handler.RequestLoggingTest.testLogBeforeExecuteWithRequestLogger
[junit4] -
org.apache.solr.handler.RequestLoggingTest.testLogBeforeExecuteWithCoreLogger
[junit4] - org.apache.solr.logging.TestLogWatcher.testLog4jWatcher
[junit4] - org.apache.solr.logging.TestLogWatcher.testLog4jWatcherRepeat
{noformat}
I did not see any super-long heartbeats in the scrollback history of the ssh
session. Logging must take up a very small percentage of test time, since this
test run was only a minute shorter than the benchmark.
When I built the server and started it, solr.log looks like it's working
correctly.
> Enable async logging by default
> -------------------------------
>
> Key: SOLR-12055
> URL: https://issues.apache.org/jira/browse/SOLR-12055
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: logging
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: SOLR-12055-slh-interim1.patch,
> SOLR-12055-slh-interim1.patch
>
>
> When SOLR-7887 is done, switching to async logging will be a simple change to
> the config files for log4j2. This will reduce contention and increase
> throughput generally and logging in particular.
> There's a discussion of the pros/cons here:
> https://logging.apache.org/log4j/2.0/manual/async.html
> An alternative is to put a note in the Ref Guide about how to enable async
> logging.
> I guess even if we enable async by default the ref guide still needs a note
> about how to _disable_ it.....
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
