[
https://issues.apache.org/jira/browse/SOLR-12055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589702#comment-16589702
]
Erick Erickson commented on SOLR-12055:
---------------------------------------
I'm trying this out and the TestLogWatcher fails (RequestLoggingTest succeeded,
but then I only ran it once). Interestingly the _second_ test always fails,
with the way TestLogWatcher is written that's always {{testLog4jWatcherRepeat.}}
But if I rearrange it so testLog4jWatcherRepeat is first, then
{{testLog4jWatcher}} fails.
Both tests do exactly the same thing before the failure.
{quote}LogWatcher watcher = LogWatcher.newRegisteredLogWatcher(config, null);
assertEquals(watcher.getLastEvent(), -1);
log.warn("This is a test message");
assertTrue(watcher.getLastEvent() > -1);
{quote}
{{the last assertTrue fails. Over in LogWatcher there's an add method that
never gets called for the failing test.}}
Anyway, I'll look more tomorrow, any hints welcome of course.
> Enable async logging by default
> -------------------------------
>
> Key: SOLR-12055
> URL: https://issues.apache.org/jira/browse/SOLR-12055
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: logging
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: SOLR-12055-slh-interim1.patch,
> SOLR-12055-slh-interim1.patch
>
>
> When SOLR-7887 is done, switching to async logging will be a simple change to
> the config files for log4j2. This will reduce contention and increase
> throughput generally and logging in particular.
> There's a discussion of the pros/cons here:
> https://logging.apache.org/log4j/2.0/manual/async.html
> An alternative is to put a note in the Ref Guide about how to enable async
> logging.
> I guess even if we enable async by default the ref guide still needs a note
> about how to _disable_ it.....
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
