[ 
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611161#comment-16611161
 ] 

Varun Thacker commented on SOLR-11836:
--------------------------------------

I think we need to modify the patch a little after Joe's comment. We shouldn't 
use nteger.MAX_VALUE explicitly from FacetStream. We should just pass down -1 
and then let JSON Facets deal with -1 as it does currently .

So essentially remove this 
{code:java}
if (this.bucketSizeLimit == -1) {
  this.bucketSizeLimit = Integer.MAX_VALUE;
}{code}

> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-11836
>                 URL: https://issues.apache.org/jira/browse/SOLR-11836
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: streaming expressions
>            Reporter: Alfonso Muñoz-Pomer Fuentes
>            Priority: Major
>              Labels: facet, streaming
>         Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet 
> function, the {{bucketSizeLimit}} parameter must have a high enough value so 
> that all results will be included. Compare this with the JSON facet API, 
> where you can use {{"limit": -1}} to achieve this. It would help if such a 
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to