[
https://issues.apache.org/jira/browse/SOLR-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626272#comment-16626272
]
David Smiley commented on SOLR-12652:
-------------------------------------
Peter, please attach a .patch file and change the workflow state to "enable
patch review". I'll commit it after the bot looks at it.
> SolrMetricManager.overridableRegistryName should be removed; it doesn't work
> ----------------------------------------------------------------------------
>
> Key: SOLR-12652
> URL: https://issues.apache.org/jira/browse/SOLR-12652
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Affects Versions: 7.1
> Reporter: David Smiley
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The {{SolrMetricManager.overridableRegistryName()}} method is a great idea
> but unfortunately in practice I've found it doesn't really work; it seems
> fundamentally flawed. +I wish it could work+. The main issue I think is
> that the callers of SMM.registerGauge/registerMetric assumes it can place a
> gauge/metric and have it be the only once there (force==true). But it won't
> be if it's shared.
> Another problem is in at least one of the reporters --
> {{JmxMetricsReporter.JmxListener#registerMBean}} will get in a race condition
> to remove an already-registered MBean but in the process of removing it,
> it'll already get removed concurrently by some other core working on the same
> name. This results in {{javax.management.InstanceNotFoundException}} logged
> as a warning; nothing serious. But I suspect conceptually there is a problem
> since which MBean should "win"? Shrug.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
