[ 
https://issues.apache.org/jira/browse/SOLR-12739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644867#comment-16644867
 ] 

Shalin Shekhar Mangar commented on SOLR-12739:
----------------------------------------------

Pushed fix for {{AutoAddReplicasIntegrationTest.testSimple()}}

{code}
SOLR-12739: Fix failures in AutoAddReplicasIntegrationTest and its sub-class.

This test too makes assumptions about how replicas are placed. In the legacy 
assignment strategy, the replica of a given collection are spread equally 
across all nodes but with the new policy based strategy, all cores across 
collections are spread out. Therefore the assumptions in this test were wrong. 
I've changed this test to use the legacy assignment policy because testing the 
autoAddReplicas feature doesn't have to depend on new replica assignment 
strategies. This change also fixes a bug in Assign which used "collection" key 
instead of "cluster" to figure out which strategy to use.


master: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/9f34a7c7
branch_7x: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/d431c1b6
{code}

> Make autoscaling policy based replica placement the default strategy for 
> placing replicas
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-12739
>                 URL: https://issues.apache.org/jira/browse/SOLR-12739
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: AutoScaling, SolrCloud
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Major
>             Fix For: 7.6, master (8.0)
>
>         Attachments: SOLR-12739.patch, SOLR-12739.patch, SOLR-12739.patch, 
> SOLR-12739.patch, SOLR-12739.patch
>
>
> Today the default placement strategy is the same one used since Solr 4.x 
> which is to select nodes on a round robin fashion. I propose to make the 
> autoscaling policy based replica placement as the default policy for placing 
> replicas.
> This is related to SOLR-12648 where even though we have default cluster 
> preferences, we don't use them unless a policy is also configured.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to