[
https://issues.apache.org/jira/browse/SOLR-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651933#comment-16651933
]
Christine Poerschke commented on SOLR-12876:
--------------------------------------------
{code}
ant beast -Dbeast.iters=1000 -Dtestcase=ShardParamsTest
-Dtests.method=testGetShardsTolerantAsBool
{code}
passed for me locally on master branch with the two commits above. Would it be
helpful to wait a bit before cherry-picking to branch_7x in case non-locally
the test fails again, or would that just be confusing w.r.t. the BadApple
report counts etc.?
> un-BadApple ShardParamsTest.testGetShardsTolerantAsBool
> -------------------------------------------------------
>
> Key: SOLR-12876
> URL: https://issues.apache.org/jira/browse/SOLR-12876
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
>
> I reviewed the test itself and searched the mailing list archive for failures
> in the last 3 years via
> https://lists.apache.org/list.html?dev@lucene.apache.org:lte=3y:ShardParamsTest.testGetShardsTolerantAsBool
> (and found no examples there but did not look elsewhere) and based on that I
> think the test can be un-BadApple-d.
> A small change
> {code}
> - assertTrue(exception.getMessage().startsWith("invalid boolean value: "));
> + assertTrue(exception.getMessage(),
> exception.getMessage().startsWith("invalid boolean value: "));
> {code}
> might also be helpful. And {{ant beast}} ing of course too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
