[
https://issues.apache.org/jira/browse/SOLR-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654540#comment-16654540
]
Erick Erickson commented on SOLR-12876:
---------------------------------------
Hmmm, I've been collection Hoss's weekly rollups and have the following
failures. The date of the file is (roughly) the Monday I collected the test
rollup for the previous week. So I guess there's a mis-match between those
rollups and the list archives.
That said I have no objection to un-BadApple'ing tests as you see fit. If the
failures start showing up again we can discuss.
HOSS-2018-05-29.csv:"false","org.apache.solr.common.params.ShardParamsTest","testGetShardsTolerantAsBool","0.3690036900369","271","1"
HOSS-2018-07-02.csv:"false","org.apache.solr.common.params.ShardParamsTest","testGetShardsTolerantAsBool","0.217864923747277","459","1"
HOSS-2018-07-09.csv:"false","org.apache.solr.common.params.ShardParamsTest","testGetShardsTolerantAsBool","0.236406619385343","423","1"
HOSS-2018-08-13.csv:"false","org.apache.solr.common.params.ShardParamsTest","testGetShardsTolerantAsBool","0.179856115107914","556","1"
HOSS-2018-08-27.csv:"false","org.apache.solr.common.params.ShardParamsTest","testGetShardsTolerantAsBool","0.235849056603774","424","1"
HOSS-2018-09-03.csv:"false","org.apache.solr.common.params.ShardParamsTest","testGetShardsTolerantAsBool","0.229357798165138","436","1"
HOSS-2018-09-10.csv:"false","org.apache.solr.common.params.ShardParamsTest","testGetShardsTolerantAsBool","0.252525252525253","396","1"
HOSS-2018-09-18.csv:"false","org.apache.solr.common.params.ShardParamsTest","testGetShardsTolerantAsBool","0.207900207900208","481","1"
> un-BadApple ShardParamsTest.testGetShardsTolerantAsBool
> -------------------------------------------------------
>
> Key: SOLR-12876
> URL: https://issues.apache.org/jira/browse/SOLR-12876
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
>
> I reviewed the test itself and searched the mailing list archive for failures
> in the last 3 years via
> https://lists.apache.org/[email protected]:lte=3y:ShardParamsTest.testGetShardsTolerantAsBool
> (and found no examples there but did not look elsewhere) and based on that I
> think the test can be un-BadApple-d.
> A small change
> {code}
> - assertTrue(exception.getMessage().startsWith("invalid boolean value: "));
> + assertTrue(exception.getMessage(),
> exception.getMessage().startsWith("invalid boolean value: "));
> {code}
> might also be helpful. And {{ant beast}} ing of course too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
