[
https://issues.apache.org/jira/browse/SOLR-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16683807#comment-16683807
]
Christine Poerschke commented on SOLR-12881:
--------------------------------------------
bq. ... cleanup ...
+1
Could we perhaps also do something to prevent re-introductions i.e. to keep
things shiny after cleanup?
* Perhaps
https://github.com/apache/lucene-solr/blob/master/lucene/tools/src/groovy/check-source-patterns.groovy
(or [~thetaphi]'s
https://github.com/apache/lucene-solr/tree/master/lucene/tools/forbiddenApis ?)
could guard against {{import java.lang}} re-introduction?
* In
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.5.0/dev-tools/eclipse/dot.settings/org.eclipse.jdt.core.prefs#L34
and
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.5.0/lucene/tools/javadoc/ecj.javadocs.prefs#L85
we currently have
{{org.eclipse.jdt.core.compiler.problem.unusedImport=error}} and the latter
file is used by precommit. Not sure if something equivalent specifically
looking for same-package imports exists?
> Remove unneeded import statements
> ---------------------------------
>
> Key: SOLR-12881
> URL: https://issues.apache.org/jira/browse/SOLR-12881
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: master (8.0)
> Reporter: Peter Somogyi
> Assignee: Erick Erickson
> Priority: Trivial
> Attachments: SOLR-12881.patch, SOLR-12881.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are unnecessary import statements:
> * import from java.lang
> * import from same package
> * unused import
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
