Github user jimczi commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/495#discussion_r233797436
  
    --- Diff: 
lucene/core/src/test/org/apache/lucene/search/TestConjunctionDISI.java ---
    @@ -234,12 +234,12 @@ public void testConjunction() throws IOException {
               case 0:
                 // simple iterator
                 sets[i] = set;
    -            iterators[i] = new ConstantScoreScorer(new FakeWeight(), 0f, 
anonymizeIterator(new BitDocIdSet(set).iterator()));
    +            iterators[i] = new ConstantScoreScorer(new FakeWeight(), 0f, 
ScoreMode.TOP_SCORES, anonymizeIterator(new BitDocIdSet(set).iterator()));
    --- End diff --
    
    I'd use `SearchMode.COMPLETE_NO_SCORES` to make sure that the expected 
behavior in the test doesn't change.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to