Github user cbismuth commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/495#discussion_r233838121
  
    --- Diff: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java 
---
    @@ -766,7 +766,7 @@ public ScorerSupplier scorerSupplier(LeafReaderContext 
context) throws IOExcepti
           return new ScorerSupplier() {
             @Override
             public Scorer get(long LeadCost) throws IOException {
    -          return new ConstantScoreScorer(CachingWrapperWeight.this, 0f, 
disi);
    +          return new ConstantScoreScorer(CachingWrapperWeight.this, 0f, 
ScoreMode.TOP_SCORES, disi);
    --- End diff --
    
    I see, [query caching is related to 
filters](https://wiki.apache.org/lucene-java/LuceneFAQ?highlight=%28query%29%7C%28cache%29#Can_I_cache_search_results_with_Lucene.3F),
 so no score, thanks :+1:
    
    Fixed in d114c02d4cd035b2c0d4480225f8064698784a7e.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to