[
https://issues.apache.org/jira/browse/LUCENE-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725086#comment-16725086
]
David Smiley commented on LUCENE-8581:
--------------------------------------
Great work!
I was looking through the code and found some re-use of public static final
BYTES constants that I have doubts we should have.
# Why is Rectangle2D referring to LatLonShape.BYTES ? Instead, Shouldn't it
define a private BYTES as Integer.BYTES? After all, it is this class that
encodes/decodes them into a byte array using intToSortableBytes.
# Why is LatLonShape.BYTES referring to LatLonPoint.BYTES? I think it should
define it as Integer.BYTES directly. I also think it could/should be private
(or at least package level).
> Change LatLonShape encoding to use 4 BYTES Per Dimension
> --------------------------------------------------------
>
> Key: LUCENE-8581
> URL: https://issues.apache.org/jira/browse/LUCENE-8581
> Project: Lucene - Core
> Issue Type: New Feature
> Reporter: Nicholas Knize
> Assignee: Ignacio Vera
> Priority: Major
> Fix For: master (8.0), 7.7
>
> Attachments: LUCENE-8581.patch, LUCENE-8581.patch, LUCENE-8581.patch,
> LUCENE-8581.patch, LUCENE-8581.patch, LUCENE-8581.patch, LUCENE-8581.patch,
> LUCENE-8581.patch
>
>
> {{LatLonShape}} tessellated triangles currently use a relatively naive
> encoding with the first four dimensions as the bounding box of the triangle
> and the last three dimensions as the vertices of the triangle. To encode the
> {{x,y}} vertices in the last three dimensions requires {{bytesPerDim}} to be
> set to 8, with 4 bytes for the x & y axis, respectively. We can reduce
> {{bytesPerDim}} to 4 by encoding the index(es) of the vertices shared by the
> bounding box along with the orientation of the triangle. This also opens the
> door for supporting {{CONTAINS}} queries.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
