[ https://issues.apache.org/jira/browse/LUCENE-8620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730119#comment-16730119 ]
Ignacio Vera commented on LUCENE-8620: -------------------------------------- Some notes about the patch: {{Tessellator}}: It captures if an edge of a generated triangle belongs to the original polygon. We need to be careful now when removing coplanar points. We need to make sure the edges we are merging have the same value in this new property. {{LatLonShape}}: I have added a new triangle class to capture the decoded values. Note that now there are two triangle classes, one belonging to the Tessellator and this one. The difference between them is that the Tessellator triangle contains the original values. {{LatLonshapeQuery}}: I have added the method {{queryWithIn}} that return a {{Boolean}} object so we have three return values: * {{Boolean.TRUE}}: The shape is a candidate for {{CONTAINS}}. Either the query shape is inside the triangle or intersect an edge that does not belong to the query shape. * {{Boolean.FALSE}}: The triangle intersects a query shape edge or the triangle is inside the query shape. * {{null}}: Triangle is disjoint, we cannot discard it nor add it to the answer. I have not reused the values from {{PointValues.Relation}} as they have a different meaning. > Add CONTAINS support for LatLonShape > ------------------------------------ > > Key: LUCENE-8620 > URL: https://issues.apache.org/jira/browse/LUCENE-8620 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/sandbox > Reporter: Ignacio Vera > Priority: Major > Attachments: LUCENE-8620.patch > > > Currently the only spatial operation that cannot be performed using > {{LatLonShape}} is CONTAINS. This issue will add such capability by tracking > if an edge of a generated triangle from the {{Tessellator}} is an edge of the > polygon. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org