Adrien Grand commented on LUCENE-8620:

bq. or I can implement it now and perform some mapping for Polygon2D.

+1 to having two enums rather than reusing Boolean

I started looking and have the below comments, but it's a bit hard to review 
due to the size of the patch, would you mind opening a PR to make it easier?
 - Why does withinTriangle always return false if the box crosses the dateline? 
Don't we need to check whether the triangle and the box are disjoint? (which 
would map to null as a return value)
 - bboxWithinTriangle could be private?

> Add CONTAINS support for LatLonShape
> ------------------------------------
>                 Key: LUCENE-8620
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8620
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/sandbox
>            Reporter: Ignacio Vera
>            Priority: Major
>             Fix For: 8.0, 7.7
>         Attachments: LUCENE-8620.patch, LUCENE-8620.patch
> Currently the only spatial operation that cannot be performed using 
> {{LatLonShape}} is CONTAINS. This issue will add such capability by tracking 
> if an edge of a generated triangle from the {{Tessellator}} is an edge of the 
> polygon.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to