[
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732971#comment-16732971
]
Shalin Shekhar Mangar commented on SOLR-11126:
----------------------------------------------
Thanks Amrit. A few comments:
# The CommonParams used to have {{/admin/health}} but now has
{{/admin/info/health}}. It is okay to change the path because this API has
never been released but there is some inconsistency because
ImplicitPlugins.json still has {{"/admin/health"}}
# HealthCheckHandler -- the {{cores != null} check is redundant and the if
condition can be simplified to {{if(cores == null || cores.isShutDown())}}
# HealthCheckHandler -- redundant return statement at the end of the
handleRequestBody method
# Please make a note in the reference guide that this health check handler is
only available in solrcloud mode
# There should be at least one test which tests the v2 API
# The test can make use of the expectThrows pattern. See the changes made in
SOLR-12555 for examples.
> Node-level health check handler
> -------------------------------
>
> Key: SOLR-11126
> URL: https://issues.apache.org/jira/browse/SOLR-11126
> Project: Solr
> Issue Type: New Feature
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Anshum Gupta
> Assignee: Anshum Gupta
> Priority: Major
> Fix For: master (8.0)
>
> Attachments: SOLR-11126-v2.patch, SOLR-11126.patch, SOLR-11126.patch
>
>
> Solr used to have the PING handler at core level, but with SolrCloud, we are
> missing a node level health check handler. It would be good to have. The API
> would look like:
> * solr/admin/health (v1 API)
> * solr/node/health (v2 API)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
