[ 
https://issues.apache.org/jira/browse/SOLR-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733958#comment-16733958
 ] 

Amrit Sarkar commented on SOLR-11126:
-------------------------------------

Thanks, Shalin, apologies you had to review multiple times. I didn't think this 
point through and moved forward with changes:

bq. The CommonParams used to have /admin/health but now has /admin/info/health. 
It is okay to change the path because this API has never been released but 
there is some inconsistency because ImplicitPlugins.json still has 
"/admin/health"

The following is mentioned in the {{ImplicitPlugins}} documentation: 

{code}
System Settings 
Return server statistics and settings.

Documentation: 
https://wiki.apache.org/solr/SystemInformationRequestHandlers#SystemInfoHandler

API Endpoints   Class & Javadocs        Paramset
v1: solr/admin/info/system

v2: api/node/system
{solr-javadocs}/solr-core/org/apache/solr/handler/admin/SystemInfoHandler.html[SystemInfoHandler]
_ADMIN_SYSTEM
This endpoint can also take the collection or core name in the path 
(solr/<collection>/admin/system or solr/<core>/admin/system) which will include 
all of the system-level information and additional information about the 
specific core that served the request.
{code}

All the InfoHandlers are available with 
{{/solr/<collection>/admin/<endpoint>}}; which is essentially utilized by 
SolrClient. Thus, all info endpoints are mentioned in ImplicitPlugins.json.

{code}
    "/admin/plugins": {
      "class": "solr.PluginInfoHandler"
    },
    "/admin/threads": {
      "class": "solr.ThreadDumpHandler",
      "useParams":"_ADMIN_THREADS"
    },
    "/admin/properties": {
      "class": "solr.PropertiesRequestHandler",
      "useParams":"_ADMIN_PROPERTIES"
    },
    "/admin/logging": {
      "class": "solr.LoggingHandler",
      "useParams":"_ADMIN_LOGGING"
    },
{code}

Since this endpoint is available only in Solrcloud mode, I have added another 
line in the documentation. Beasts 100 rounds run successfully, precommit pass.

> Node-level health check handler
> -------------------------------
>
>                 Key: SOLR-11126
>                 URL: https://issues.apache.org/jira/browse/SOLR-11126
>             Project: Solr
>          Issue Type: New Feature
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Anshum Gupta
>            Assignee: Shalin Shekhar Mangar
>            Priority: Major
>             Fix For: master (8.0)
>
>         Attachments: SOLR-11126-v2.patch, SOLR-11126.patch, SOLR-11126.patch, 
> SOLR-11126.patch, SOLR-11126.patch
>
>
> Solr used to have the PING handler at core level, but with SolrCloud, we are 
> missing a node level health check handler. It would be good to have. The API 
> would look like:
> * solr/admin/health (v1 API)
> * solr/node/health (v2 API)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to