[ 
https://issues.apache.org/jira/browse/LUCENE-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16744964#comment-16744964
 ] 

ASF subversion and git services commented on LUCENE-8642:
---------------------------------------------------------

Commit f2352e9456e9520c75a792533c3de3bf7e58f777 in lucene-solr's branch 
refs/heads/master from Dawid Weiss
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f2352e9 ]

Revert "LUCENE-8642, LUCENE-8641: correct RamUsageTester.sizeOf's handling of 
ByteBuffers. Throw exceptions on denied reflection to catch problems early. 
This affects tests only."

This reverts commit a16f0833edb744e7bd0dfadce7e7d41e1d3aee2c.


> RamUsageTester.sizeOf ignores arrays and collections if --illegal-access=deny
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-8642
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8642
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: master (9.0)
>
>
> We have a silent fall-through on catch clause there if a field is 
> inaccessible. This causes all collections to not be recursively descended 
> into.
> We could hack it so that collection objects are counted "manually". Or we 
> could propagate illegal access exception from ram tester, detect which tests/ 
> objects do try to measure collection objects and either remove them (if it's 
> not possible to measure accurately) or change them (if it is possible to 
> estimate the size in a different way).
> Looking for feedback on this one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to