jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape 
contains
URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249810439
 
 

 ##########
 File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java
 ##########
 @@ -224,7 +313,7 @@ private static boolean bboxContainsTriangle(int ax, int 
ay, int bx, int by, int
         && bboxContainsPoint(cx, cy, minX, maxX, minY, maxY);
   }
 
-  /** returns true if the edge (defined by (ax, ay) (bx, by)) intersects the 
query */
+  /** returns true if the edge (defined by (ax, ay) (bx, by)) crosses the 
query */
 
 Review comment:
   docs don't match the method name?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to