jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape
contains
URL: https://github.com/apache/lucene-solr/pull/546#discussion_r249797707
##########
File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java
##########
@@ -150,9 +204,88 @@ private Relation internalComponentRelateTriangle(double
ax, double ay, double bx
if (tree.crossesTriangle(ax, ay, bx, by, cx, cy)) {
return Relation.CELL_CROSSES_QUERY;
}
+ if (pointInTriangle(tree.lon1, tree.lat1, ax, ay, bx, by, cx, cy) == true)
{
+ return Relation.CELL_CROSSES_QUERY;
+ }
Review comment:
This looks like an unrelated bug, let's have a dedicated issue for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
