jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape
contains
URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250101242
##########
File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java
##########
@@ -101,6 +101,60 @@ public Relation relateTriangle(double ax, double ay,
double bx, double by, doubl
return Relation.CELL_OUTSIDE_QUERY;
}
+ /** Used by withinTriangle to check the within relationship between a
triangle and the query shape */
+ public enum WithinRelation {
+ /** If the shape is a candidate for within. Typically this is return if
the query shape is fully inside
+ * the triangle or if the query shape intersects only edges that do not
belong to the original shape. */
+ CANDIDATE,
+ /** Return this if if the query shape intersects an edge that does belong
to the original shape. */
Review comment:
update javadocs to say "crosses" instead of intersects?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
