jpountz commented on a change in pull request #546: LUCENE-8620: LatLonShape 
contains
URL: https://github.com/apache/lucene-solr/pull/546#discussion_r250101885
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java
 ##########
 @@ -158,6 +212,61 @@ private Relation internalComponentRelateTriangle(double 
ax, double ay, double bx
     return Relation.CELL_OUTSIDE_QUERY;
   }
 
+  private WithinRelation internalWithinTriangle(double ax, double ay, boolean 
ab, double bx, double by, boolean bc, double cx, double cy, boolean ca) {
+    // compute bounding box of triangle
+    double minLat = StrictMath.min(StrictMath.min(ay, by), cy);
+    double minLon = StrictMath.min(StrictMath.min(ax, bx), cx);
+    double maxLat = StrictMath.max(StrictMath.max(ay, by), cy);
+    double maxLon = StrictMath.max(StrictMath.max(ax, bx), cx);
+
+    //disjoint then we return null
 
 Review comment:
   outdated?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to