[ 
https://issues.apache.org/jira/browse/SOLR-13213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16759575#comment-16759575
 ] 

Jan Høydahl commented on SOLR-13213:
------------------------------------

See [https://github.com/apache/lucene-solr/pull/560] for proposed fix. We split 
method {{getAndPrepShardHandler()}} in two pieces. Before call to 
{{SC#prepare}} we set {{rb.isDistrib}} since this is needed by 
{{DebugComponent}}, and after {{SC#prepare}} we do the remaining part of 
{{getAndPrepShardHandler()}}. All tests pass.

> Search Components cannot modify "shards" parameter
> --------------------------------------------------
>
>                 Key: SOLR-13213
>                 URL: https://issues.apache.org/jira/browse/SOLR-13213
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: search
>            Reporter: Jan Høydahl
>            Priority: Major
>             Fix For: 8.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When creating a custom search component for a customer, I realised that 
> modifying "shards" parameter in {{prepare()}} is not possible since the 
> "shards" parameter is read from request in 
> {{SearchHandler#handleRequestBody}} in {{getAndPrepShardHandler()}} just 
> before search components are consulted, after which it is too late to change 
> it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to