[ 
https://issues.apache.org/jira/browse/SOLR-13213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760296#comment-16760296
 ] 

Jan Høydahl commented on SOLR-13213:
------------------------------------

Yea, I first tried to move the shardHandler init below prepare but that broke 
some logic in DebugComponent. And even if tests pass by prepping isDistrib, I 
guess that custom stuff may assume som order. Although the type og logic 
(change some query params, amend the result) is perfect for SearchComponent, I 
may agree with you that due to the chicken/egg nature of isDistrib it may be 
safer to set this in a custom SearchHandler, although that beast is not as 
nicely extensible as components, i.e. the handleRequestBody is one huge code 
block. I'll try and if successful I'll close this jira.

> Search Components cannot modify "shards" parameter
> --------------------------------------------------
>
>                 Key: SOLR-13213
>                 URL: https://issues.apache.org/jira/browse/SOLR-13213
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: search
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>            Priority: Major
>             Fix For: 8.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When creating a custom search component for a customer, I realised that 
> modifying "shards" parameter in {{prepare()}} is not possible since in 
> {{SearchHandler}}, the {{ShardHandler}} is initialised based on "shards" 
> parameter just *before* search components are consulted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to