romseygeek commented on issue #581: LUCENE-3041: QueryVisitor URL: https://github.com/apache/lucene-solr/pull/581#issuecomment-465948613 I've pushed some changes: * removed the Supplier generalization; this was intended to help with highlighting AutomatonQuery implementations, but let's deal with that when we need to * replaced the usage of extractTerms() with appropriate visitors - the nice thing here is that because most of the methods on QueryVisitor have default implementations, you can just do `Query.visit(terms::add)` as a replacement; but you can also see immediate improvements in things like QueryTermExtractor in highlighter, which no longer needs its big tree of instanceof checks
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
