romseygeek commented on issue #581: LUCENE-3041: QueryVisitor URL: https://github.com/apache/lucene-solr/pull/581#issuecomment-467448787 * I've taken Simon's suggestion of removing special-casing for Automaton, and things still seem to work (although we may need to add hooks back in to allow handling of custom multi-term queries). * I've renamed matchesTerm() to consumesTerm(), and changed the sig to include the Query doing the consuming (otherwise we can't tell if a leaf query is a TermQuery or something else). * QueryVisitor.EMPTY_VISITOR is back, nulls are gone * I've also removed Weight.extractTerms() entirely - I can revert this last commit if it makes the patch too big, but it does increase the number of lines removed by a lot, which is nice :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
