[ 
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777135#comment-16777135
 ] 

Kevin Risden commented on SOLR-13268:
-------------------------------------

So I would guess that Solr isn't doing something right when it comes to 
logging. I haven't dug in to the details of how Solr does logging. There have 
only been a few failures related to log4j threads after adding the log4j-web 
dependency. Maybe we can collect those failures and see if there is a common 
theme. I have a few of the failures collected on my local Jenkins server but 
haven't sat down to look at them. I probably won't for a few days.

Either way, the failures have gone down significantly recently. I don't think 
ignoring the leaked threads is correct. I also don't think adding shutdown is 
correct since that didn't seem to help. Also not sure this is a bad idea. If 
Solr is starting/stopping logging correctly, then I doubt we would have issues 
like this. Maybe we only see these start/stop issues due to the async logging 
since that type of logging is more sensitive to specific start/stop handling.

> Clean up any test failures resulting from defaulting to async logging
> ---------------------------------------------------------------------
>
>                 Key: SOLR-13268
>                 URL: https://issues.apache.org/jira/browse/SOLR-13268
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-13268.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> This is a catch-all for test failures due to the async logging changes. So 
> far, the I see a couple failures on JDK13 only. I'll collect a "starter set" 
> here, these are likely systemic, once the root cause is found/fixed, then 
> others are likely fixed as well.
> JDK13:
> ant test  -Dtestcase=TestJmxIntegration -Dtests.seed=54B30AC62A2D71E 
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=lv-LV 
> -Dtests.timezone=Asia/Riyadh -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> ant test  -Dtestcase=TestDynamicURP -Dtests.seed=54B30AC62A2D71E 
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=rwk 
> -Dtests.timezone=Australia/Brisbane -Dtests.asserts=true 
> -Dtests.file.encoding=UTF-8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to