[ https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777383#comment-16777383 ]
Kevin Risden commented on SOLR-13268: ------------------------------------- [~erickerickson] so I played around with this a bit and I don't understand what I am seeing... * BufferStoreTest reproduces with the above seed * BufferStoreTest changed to extend SolrTestCaseJ4 - test passes * So I played around with SolrTestCaseJ4 ** If you comment out the entire file - seed fails (as expected) ** Comment out EVERYTHING except for *** private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); *** Test passes * Revert changes and make only the following change to BufferStoreTest: ** Add "private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());" So basically if there is a LoggerFactory.getLogger, the test passes. Otherwise there is an issue with thread hanging. I checked IgnoreLargeDocumentProcessorFactoryTest, and it doesn't extend SolrTestCaseJ4 and doesn't call LoggerFactory. I don't think adding "private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());" to tests is the correct answer but it definitely is an interesting finding. > Clean up any test failures resulting from defaulting to async logging > --------------------------------------------------------------------- > > Key: SOLR-13268 > URL: https://issues.apache.org/jira/browse/SOLR-13268 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Erick Erickson > Assignee: Erick Erickson > Priority: Major > Attachments: SOLR-13268.patch > > Time Spent: 40m > Remaining Estimate: 0h > > This is a catch-all for test failures due to the async logging changes. So > far, the I see a couple failures on JDK13 only. I'll collect a "starter set" > here, these are likely systemic, once the root cause is found/fixed, then > others are likely fixed as well. > JDK13: > ant test -Dtestcase=TestJmxIntegration -Dtests.seed=54B30AC62A2D71E > -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=lv-LV > -Dtests.timezone=Asia/Riyadh -Dtests.asserts=true -Dtests.file.encoding=UTF-8 > ant test -Dtestcase=TestDynamicURP -Dtests.seed=54B30AC62A2D71E > -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=rwk > -Dtests.timezone=Australia/Brisbane -Dtests.asserts=true > -Dtests.file.encoding=UTF-8 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org