romseygeek commented on a change in pull request #581: LUCENE-3041: QueryVisitor
URL: https://github.com/apache/lucene-solr/pull/581#discussion_r260199400
##########
File path: lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java
##########
@@ -135,6 +138,20 @@ private boolean equalsTo(TermInSetQuery other) {
termData.equals(other.termData);
}
+ @Override
+ public void visit(QueryVisitor visitor) {
+ visitor.matchesAutomaton(this, field, true, this::toAutomaton);
Review comment:
This should probably use a DaciukMihov automaton, as it's just fixed strings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
