romseygeek commented on a change in pull request #581: LUCENE-3041: QueryVisitor
URL: https://github.com/apache/lucene-solr/pull/581#discussion_r260244078
##########
File path: lucene/core/src/java/org/apache/lucene/search/PhraseQuery.java
##########
@@ -284,6 +284,16 @@ public Query rewrite(IndexReader reader) throws
IOException {
}
}
+ @Override
+ public void visit(QueryVisitor visitor) {
+ for (Term term : terms) {
+ QueryVisitor v = visitor.getSubVisitor(BooleanClause.Occur.MUST, this);
Review comment:
The advantage of pulling multiple times is the combination with the null
check, meaning we can short-circuit; it's particularly useful on something like
BooleanQuery or DisjunctionQuery, where if you're say looking to see if there's
a single instance of a particular term or query type, you can stop looking as
soon as you find it rather than having to continue traversing through all the
possibilities
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
