[ 
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778225#comment-16778225
 ] 

Kevin Risden commented on SOLR-13268:
-------------------------------------

Yea so I think #1 is a decent approach. Also having a precommit failure to keep 
it from coming back would be good. Maybe 
./lucene/tools/src/groovy/check-source-patterns.groovy since I know there are 
existing checks for logger patterns in there and a check for mockito on tests 
around like 170.

 

FWIW I think this is only a test problem like you had said previously. Since I 
think tests are the only place the JVM is not shutdown between usage of the 
LogManager.

> Clean up any test failures resulting from defaulting to async logging
> ---------------------------------------------------------------------
>
>                 Key: SOLR-13268
>                 URL: https://issues.apache.org/jira/browse/SOLR-13268
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-13268.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> This is a catch-all for test failures due to the async logging changes. So 
> far, the I see a couple failures on JDK13 only. I'll collect a "starter set" 
> here, these are likely systemic, once the root cause is found/fixed, then 
> others are likely fixed as well.
> JDK13:
> ant test  -Dtestcase=TestJmxIntegration -Dtests.seed=54B30AC62A2D71E 
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=lv-LV 
> -Dtests.timezone=Asia/Riyadh -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> ant test  -Dtestcase=TestDynamicURP -Dtests.seed=54B30AC62A2D71E 
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=rwk 
> -Dtests.timezone=Australia/Brisbane -Dtests.asserts=true 
> -Dtests.file.encoding=UTF-8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to