[
https://issues.apache.org/jira/browse/SOLR-13234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782977#comment-16782977
]
ASF subversion and git services commented on SOLR-13234:
--------------------------------------------------------
Commit 1f9c767aac76ac1618ccaffce42524e109335fe8 in lucene-solr's branch
refs/heads/master from Shalin Shekhar Mangar
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1f9c767 ]
SOLR-13234: Prometheus Metric Exporter not threadsafe.
This changes the prometheus exporter to collect metrics from Solr on a fixed
interval controlled by this tool and prevents concurrent collections. This
change also improves performance slightly by using the cluster state instead of
sending multiple HTTP requests to each node to lookup all the cores.
This closes #571.
> Prometheus Metric Exporter Not Threadsafe
> -----------------------------------------
>
> Key: SOLR-13234
> URL: https://issues.apache.org/jira/browse/SOLR-13234
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Affects Versions: 7.6, 8.0
> Reporter: Danyal Prout
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Labels: metric-collector
> Fix For: 8.x, master (9.0)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The Solr Prometheus Exporter collects metrics when it receives a HTTP request
> from Prometheus. Prometheus sends this request, on its [scrape
> interval|https://prometheus.io/docs/prometheus/latest/configuration/configuration/#scrape_config].
> When the time taken to collect the Solr metrics is greater than the scrape
> interval of the Prometheus server, this results in concurrent metric
> collection occurring in this
> [method|https://github.com/apache/lucene-solr/blob/master/solr/contrib/prometheus-exporter/src/java/org/apache/solr/prometheus/collector/SolrCollector.java#L86].
> This method doesn’t appear to be thread safe, for instance you could have
> concurrent modifications of a
> [map|https://github.com/apache/lucene-solr/blob/master/solr/contrib/prometheus-exporter/src/java/org/apache/solr/prometheus/collector/SolrCollector.java#L119].
> After a while the Solr Exporter processes becomes nondeterministic, we've
> observed NPE and loss of metrics.
> To address this, I'm proposing the following fixes:
> 1. Read/parse the configuration at startup and make it immutable.
> 2. Collect metrics from Solr on an interval which is controlled by the Solr
> Exporter and cache the metric samples to return during Prometheus scraping.
> Metric collection can be expensive, for example executing arbitrary Solr
> searches, it's not ideal to allow for concurrent metric collection and on an
> interval which is not defined by the Solr Exporter.
> There are also a few other performance improvements that we've made while
> fixing this, for example using the ClusterStateProvider instead of sending
> multiple HTTP requests to each Solr node to lookup all the cores.
> I'm currently finishing up these changes which I'll submit as a PR.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
