[
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785770#comment-16785770
]
Kevin Risden commented on SOLR-13268:
-------------------------------------
My rough two cents are, we should have a base class that all Solr tests extend
from. That should allow for cleanup like this and to standardize the
environment that Solr tests run in.
I think if there is a class that extends LuceneTestCase (lets say SolrTestCase)
it could have a AfterClass or After method that automatically shuts down the
logger. Should not need to call it anywhere else. SolrTestCaseJ4 could extend
SolrTestCase and it would get the shutdown for free?
> Clean up any test failures resulting from defaulting to async logging
> ---------------------------------------------------------------------
>
> Key: SOLR-13268
> URL: https://issues.apache.org/jira/browse/SOLR-13268
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-13268.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This is a catch-all for test failures due to the async logging changes. So
> far, the I see a couple failures on JDK13 only. I'll collect a "starter set"
> here, these are likely systemic, once the root cause is found/fixed, then
> others are likely fixed as well.
> JDK13:
> ant test -Dtestcase=TestJmxIntegration -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=lv-LV
> -Dtests.timezone=Asia/Riyadh -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> ant test -Dtestcase=TestDynamicURP -Dtests.seed=54B30AC62A2D71E
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=rwk
> -Dtests.timezone=Australia/Brisbane -Dtests.asserts=true
> -Dtests.file.encoding=UTF-8
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
