[ 
https://issues.apache.org/jira/browse/SOLR-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785763#comment-16785763
 ] 

Erick Erickson commented on SOLR-13268:
---------------------------------------

OK, 2 days later rather than "later today".

I've been uncomfortable with bringing in the added cruft from SolrTestCaseJ4 to 
150+ Solr test cases for two reasons:

1> it seems like it might add to the test run length (although on a couple of 
quick tests this seems lost in the noise).

2> The additional setup etc. in SolrTestCaseJ4 may affect tests. There's 
already one test for which this is true, there may be others over time.

So I'm thinking about a new class subclassing LuceneTestCase whose only 
function is to call the shutdown hook and calling _that_ from both 
SolrTestCaseJ4 and the tests that currently subclass LuceneTestCase. Comments?

> Clean up any test failures resulting from defaulting to async logging
> ---------------------------------------------------------------------
>
>                 Key: SOLR-13268
>                 URL: https://issues.apache.org/jira/browse/SOLR-13268
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-13268.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> This is a catch-all for test failures due to the async logging changes. So 
> far, the I see a couple failures on JDK13 only. I'll collect a "starter set" 
> here, these are likely systemic, once the root cause is found/fixed, then 
> others are likely fixed as well.
> JDK13:
> ant test  -Dtestcase=TestJmxIntegration -Dtests.seed=54B30AC62A2D71E 
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=lv-LV 
> -Dtests.timezone=Asia/Riyadh -Dtests.asserts=true -Dtests.file.encoding=UTF-8
> ant test  -Dtestcase=TestDynamicURP -Dtests.seed=54B30AC62A2D71E 
> -Dtests.multiplier=3 -Dtests.slow=true -Dtests.locale=rwk 
> -Dtests.timezone=Australia/Brisbane -Dtests.asserts=true 
> -Dtests.file.encoding=UTF-8



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to