risdenk commented on a change in pull request #599: SOLR-13307: Ensure HDFS
tests clear System properties they set
URL: https://github.com/apache/lucene-solr/pull/599#discussion_r263789863
##########
File path:
solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsRecoveryZkTest.java
##########
@@ -51,9 +51,17 @@ public static void setupClass() throws Exception {
@AfterClass
public static void teardownClass() throws Exception {
- cluster.shutdown(); // need to close before the MiniDFSCluster
- HdfsTestUtil.teardownClass(dfsCluster);
- dfsCluster = null;
+ try {
+ shutdownCluster(); // need to close before the MiniDFSCluster
+ } finally {
+ try {
+ HdfsTestUtil.teardownClass(dfsCluster);
+ } finally {
+ dfsCluster = null;
+ System.clearProperty("solr.hdfs.blockcache.blocksperbank");
Review comment:
Has never been cleaned up before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
