risdenk commented on a change in pull request #599: SOLR-13307: Ensure HDFS
tests clear System properties they set
URL: https://github.com/apache/lucene-solr/pull/599#discussion_r263789777
##########
File path:
solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsChaosMonkeyNothingIsSafeTest.java
##########
@@ -33,20 +33,23 @@
@ThreadLeakFilters(defaultFilters = true, filters = {
BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
})
-// commented out on: 24-Dec-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028,
https://issues.apache.org/jira/browse/SOLR-10191";)
public class HdfsChaosMonkeyNothingIsSafeTest extends
ChaosMonkeyNothingIsSafeTest {
private static MiniDFSCluster dfsCluster;
@BeforeClass
public static void setupClass() throws Exception {
- dfsCluster =
HdfsTestUtil.setupClass(createTempDir().toFile().getAbsolutePath());
System.setProperty("solr.hdfs.blockcache.global", "true"); // always use
global cache, this test can create a lot of directories
+ dfsCluster =
HdfsTestUtil.setupClass(createTempDir().toFile().getAbsolutePath());
}
@AfterClass
public static void teardownClass() throws Exception {
- HdfsTestUtil.teardownClass(dfsCluster);
- dfsCluster = null;
+ try {
+ HdfsTestUtil.teardownClass(dfsCluster);
+ } finally {
+ dfsCluster = null;
+ System.clearProperty("solr.hdfs.blockcache.global");
Review comment:
Has never been cleaned up before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
