s1monw commented on a change in pull request #601: Adding reader settings for
moving fst offheap
URL: https://github.com/apache/lucene-solr/pull/601#discussion_r264006366
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/blocktree/FieldReader.java
##########
@@ -88,10 +97,13 @@
if (indexIn != null) {
final IndexInput clone = indexIn.clone();
+ //System.out.println("start=" + indexStartFP + " field=" +
fieldInfo.name);
clone.seek(indexStartFP);
- // Initialize FST offheap if index is MMapDirectory and
- // docCount != sumDocFreq implying field is not primary key
- if (clone instanceof ByteBufferIndexInput && this.docCount !=
this.sumDocFreq) {
+
+ final boolean fstOffHeap = readerAttributes != null &&
"true".equals(readerAttributes.get(FST_OFFHEAP_ATTRIBUTE));
Review comment:
don't we want to have a per-field setting? I mean something like:
`"true".equals(readerAttributes.get("blocktree.fst." + fieldInfo.name +
".offheap"));`
this would be more flexible no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
