s1monw commented on a change in pull request #601: Adding reader settings for
moving fst offheap
URL: https://github.com/apache/lucene-solr/pull/601#discussion_r264006191
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java
##########
@@ -482,6 +483,15 @@ public IndexWriterConfig setCommitOnClose(boolean
commitOnClose) {
return this;
}
+ /**
+ * Sets read time attributes that will be loaded into SegmentReadState while
+ * opening the index
+ */
+ public IndexWriterConfig setReaderAttributes(Map<String, String>
readerAttributes) {
+ this.readerAttributes = readerAttributes;
Review comment:
this one should be an unmodifiable map, you should also make a copy for the
attributes passed in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
