jainankitk commented on a change in pull request #601: Adding reader settings
for moving fst offheap
URL: https://github.com/apache/lucene-solr/pull/601#discussion_r264099938
##########
File path: lucene/core/src/java/org/apache/lucene/store/Directory.java
##########
@@ -48,6 +49,12 @@
* @see FilterDirectory
*/
public abstract class Directory implements Closeable {
+
+ /**
+ * Reader only attributes for this directory.
+ */
+ private Map<String, String> readerAttributes;
Review comment:
>I don't think Directory is the right abstraction to hold this.
Is that because single directory can be opened in multiple contexts?
>Subsequent reopens then inherit the attributes form the reader. You can
also then make this a property of DirecotryReader I guess.
How is the attribute map passed to SegmentReadState in this approach? Also,
IndexWriterConfig need not be changed with this approach, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
