jainankitk commented on a change in pull request #601: Adding reader settings
for moving fst offheap
URL: https://github.com/apache/lucene-solr/pull/601#discussion_r264387090
##########
File path: lucene/core/src/java/org/apache/lucene/store/Directory.java
##########
@@ -48,6 +49,12 @@
* @see FilterDirectory
*/
public abstract class Directory implements Closeable {
+
+ /**
+ * Reader only attributes for this directory.
+ */
+ private Map<String, String> readerAttributes;
Review comment:
>I think such a map can be passed down to SegmentCoreReaders and then passed
on via SegmentReadState I am not sure why you think we need to change a lot of
things?
Maybe, better way is to add `readerAttributes` in `SegmentInfo`, and
populate that during `StandardDirectoryReader.open`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
