mikemccand commented on a change in pull request #606: LUCENE-8671: Allow more fine-grained control over off-heap term dictionaries URL: https://github.com/apache/lucene-solr/pull/606#discussion_r264767433
########## File path: lucene/core/src/java/org/apache/lucene/index/LiveIndexWriterConfig.java ########## @@ -499,6 +502,15 @@ public String toString() { sb.append("indexSort=").append(getIndexSort()).append("\n"); sb.append("checkPendingFlushOnUpdate=").append(isCheckPendingFlushOnUpdate()).append("\n"); sb.append("softDeletesField=").append(getSoftDeletesField()).append("\n"); + sb.append("minimizeReaderRamUsage=").append(isMinimizeReaderRamUsage()).append("\n"); return sb.toString(); } + + /** + * Returns true if the readers opened on or inside the index writer will do best effort to minimize + * it's ram usage as much as possible. The default is <code>true</code>. Review comment: `it's ram usage` -> `its ram usage` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org