mikemccand commented on a change in pull request #606: LUCENE-8671: Allow more
fine-grained control over off-heap term dictionaries
URL: https://github.com/apache/lucene-solr/pull/606#discussion_r264769778
##########
File path: lucene/core/src/java/org/apache/lucene/store/IOContext.java
##########
@@ -60,17 +64,21 @@ public IOContext(FlushInfo flushInfo) {
this.mergeInfo = null;
this.readOnce = false;
this.flushInfo = flushInfo;
+ this.minimizeRamUsage = true;
+ this.fastIdAccessRequired = false;
Review comment:
I understand the sentiment of using `IOContext` here, since it's already
distributed to many places, but I don't think this is the right place to be
putting booleans like these two? Not sure where else they could go though (and
I agree, `Directory` is also weird).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
