dsmiley commented on a change in pull request #455: SOLR-12638
URL: https://github.com/apache/lucene-solr/pull/455#discussion_r269402083
##########
File path:
solr/core/src/java/org/apache/solr/update/processor/AtomicUpdateDocumentMerger.java
##########
@@ -193,6 +194,10 @@ public static boolean
isSupportedFieldForInPlaceUpdate(SchemaField schemaField)
// not a supported in-place update op
return Collections.emptySet();
}
+ // fail fast if child doc
Review comment:
Minor: the word "fail" is suggestive of an error. I think you can simply
say we don't support in-place updates of a nested relation.
BTW maybe this loop would be more efficient to loop on the Map.Entry so that
we could eliminate the "get".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
