dsmiley commented on a change in pull request #455: SOLR-12638 URL: https://github.com/apache/lucene-solr/pull/455#discussion_r269519745
########## File path: solr/core/src/test-files/solr/collection1/conf/solrconfig-block-atomic-update.xml ########## @@ -0,0 +1,64 @@ +<?xml version="1.0" ?> + +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +<!-- + Test Config that enumerates many different update processor chain + configurations. + + --> +<config> + <luceneMatchVersion>${tests.luceneMatchVersion:LATEST}</luceneMatchVersion> + <xi:include href="solrconfig.snippet.randomindexconfig.xml" xmlns:xi="http://www.w3.org/2001/XInclude"/> + <requestHandler name="/select" class="solr.SearchHandler" /> + <requestHandler name="/update" class="solr.UpdateRequestHandler" /> + <directoryFactory name="DirectoryFactory" class="${solr.directoryFactory:solr.RAMDirectoryFactory}"/> + <schemaFactory class="ClassicIndexSchemaFactory"/> + + <updateHandler class="solr.DirectUpdateHandler2"> + + <autoCommit> + <maxTime>${solr.autoCommit.maxTime:-1}</maxTime> + </autoCommit> + + <!-- autocommit pending docs if certain criteria are met + <autoCommit> + <maxDocs>10000</maxDocs> + <maxTime>3600000</maxTime> + </autoCommit> + --> + + <updateLog enable="true"> + <str name="dir">${solr.ulog.dir:}</str> + </updateLog> + + <commitWithin> + <softCommit>${solr.commitwithin.softcommit:true}</softCommit> + </commitWithin> + + </updateHandler> + + <updateProcessor class="solr.NestedUpdateProcessorFactory" name="nested-processor"/> Review comment: Could that be avoided then? Less test files is a good thing. If can’t be then this distinction should be documented ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
