dweiss commented on a change in pull request #657: LUCENE-8781: FST direct arc
addressing
URL: https://github.com/apache/lucene-solr/pull/657#discussion_r279207910
##########
File path:
lucene/codecs/src/java/org/apache/lucene/codecs/blocktreeords/OrdsSegmentTermsEnum.java
##########
@@ -1082,12 +1082,14 @@ private InputOutput getByOutput(long targetOrd) throws
IOException {
if (FST.targetHasArcs(arc)) {
// System.out.println(" targetHasArcs");
result.grow(1+upto);
-
+ if (arc.target < 0 || arc.target > Integer.MAX_VALUE) {
Review comment:
What's the point of this block (and isn't it effectively dead code)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
