dweiss commented on a change in pull request #657: LUCENE-8781: FST direct arc 
addressing
URL: https://github.com/apache/lucene-solr/pull/657#discussion_r279269081
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/util/fst/FSTEnum.java
 ##########
 @@ -141,11 +141,65 @@ protected void doSeekCeil() throws IOException {
       //System.out.println("  cycle upto=" + upto + " arc.label=" + arc.label 
+ " (" + (char) arc.label + ") vs targetLabel=" + targetLabel);
 
       if (arc.bytesPerArc != 0 && arc.label != -1) {
+        // Arcs are in an array
 
 Review comment:
   Yes, a full refactoring is probably worth another issue, I'm just saying 
those methods evolved into complex beasts. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to