msokolov commented on a change in pull request #657: LUCENE-8781: FST direct arc addressing URL: https://github.com/apache/lucene-solr/pull/657#discussion_r279210601
########## File path: lucene/core/src/java/org/apache/lucene/util/fst/Builder.java ########## @@ -69,6 +69,8 @@ private final IntsRefBuilder lastInput = new IntsRefBuilder(); + final boolean useDirectArcAddressing; Review comment: FST reads this so it can't be private. This is following the same pattern as some existing settings like `allowArrayArcs`, which by the way should probably be final but isn't. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
