msokolov commented on a change in pull request #657: LUCENE-8781: FST direct
arc addressing
URL: https://github.com/apache/lucene-solr/pull/657#discussion_r279210936
##########
File path: lucene/core/src/java/org/apache/lucene/util/fst/FSTEnum.java
##########
@@ -141,11 +141,65 @@ protected void doSeekCeil() throws IOException {
//System.out.println(" cycle upto=" + upto + " arc.label=" + arc.label
+ " (" + (char) arc.label + ") vs targetLabel=" + targetLabel);
if (arc.bytesPerArc != 0 && arc.label != -1) {
+ // Arcs are in an array
Review comment:
I was thinking of introducing multiple Arc classes so that the (now three)
different kinds of Arc decoding methods can be modeled explicitly with function
overrides and the branching between different implementations done using
virtual function dispatch rather than inline conditionals. That would likely
subsume any refactoring here, so I'd like to postpone it, but I definitely
agree with the temptation. Still, if you think it would make the review easier,
I'd be happy to dive into that, but overall it will probably lead to more code
changes making direct comparison difficult, and I was thinking to do a separate
a refactoring commit with no behavior changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
