[
https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833258#comment-16833258
]
Elbek Kamoliddinov commented on LUCENE-8791:
--------------------------------------------
[~atris]
Hi Atri, Thanks for taking a look at the patch. So added more doc also renamed
{{Job}} and {{Jobs}} to {{SegmentRescorer}} and {{RescorerTask}} respectively,
hopefully this is more descriptive. I left {{docIDs}} as it is, this looks like
pretty standard.
I am not sure if I got the point here:
{quote}In general, I am a bit unsure about the class name and description. The
class advertises to be a Collector based rescorer implementation, whereas the
only constructor of the class takes a CollectorManager instance, which is
specific to parallel segments traversal. Should the class say that it is used
for parallel rescoring of hits across multiple segments?
{quote}
Yes, it takes {{CollectorManager}} instance and it is all it needs. Also It
makes sense to me that constructor takes {{CollectorManager}} because without
it, there is no point of creating {{CollectorRescorer}}. Also as you see It
doesn't necessarily only run in parallel. if {{ExecutorService}} is null then
it runs sequential, so calling it parallel would be wrong. JavaDoc on
constructor highlights this.
{quote}I am a bit wary of the way the patch maps the global jobs array to jobs
associated with segments belonging to one slice. In particular, buildJobs
method does not consider leaf ordinal during assigning values to the global
array, but rescore depends on that during retrieval.
{quote}
Good one, Corrected it to use ord based assignment.
Thanks.
> Add CollectorRescorer
> ---------------------
>
> Key: LUCENE-8791
> URL: https://issues.apache.org/jira/browse/LUCENE-8791
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Elbek Kamoliddinov
> Priority: Major
> Attachments: LUCENE-8791.patch, LUCENE-8791.patch
>
>
> This is another implementation of query rescorer api (LUCENE-5489). It adds
> rescoring functionality based on provided CollectorManager.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
