[
https://issues.apache.org/jira/browse/LUCENE-8791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833610#comment-16833610
]
Atri Sharma commented on LUCENE-8791:
-------------------------------------
Hi [[email protected]]
bq. Yes, it takes CollectorManager instance and it is all it needs. Also It
makes sense to me that constructor takes CollectorManager because without it,
there is no point of creating CollectorRescorer. Also as you see It doesn't
necessarily only run in parallel. if ExecutorService is null then it runs
sequential, so calling it parallel would be wrong. JavaDoc on constructor
highlights this.
Ok, I am fine with it as long as it is clearly advertised (maybe add it in the
class heading's Javadocs itself?)
bq. Corrected it to use ord based assignment.
Could you add a test for this?
I will take another deeper look into the updated patch today and post comments.
> Add CollectorRescorer
> ---------------------
>
> Key: LUCENE-8791
> URL: https://issues.apache.org/jira/browse/LUCENE-8791
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Elbek Kamoliddinov
> Priority: Major
> Attachments: LUCENE-8791.patch, LUCENE-8791.patch
>
>
> This is another implementation of query rescorer api (LUCENE-5489). It adds
> rescoring functionality based on provided CollectorManager.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
